BF: Correct viewers _on_mouse, _on_scroll for non RAS matrices #1349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1349 +/- ##
==========================================
+ Coverage 95.34% 95.36% +0.02%
==========================================
Files 207 207
Lines 29507 29646 +139
Branches 4982 4985 +3
==========================================
+ Hits 28134 28273 +139
Misses 932 932
Partials 441 441 ☔ View full report in Codecov by Sentry. |
gjpcbecq
changed the title
gjpcbecq
changed the title
|
Sorry I did not check for the style... It seems that missing or added spaces and double quotes are not validated. |
|
Just run |
Doing that asap. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the second part of the correction of bugs in viewers.py for matrices with non RAS orientation.
Corrections have been made on
_on_mouseand_on_scroll.I don't know where the original code comes from, but there was an erroneous index positioning a la Matlab style...
There was also confusing ordering of indices and matching from axis to matrices and right values to be passed to the affine transform.
I think that it can be rewritted to be more easier to understand, but I have no time now.
Best regards,
Guillaume